Search found 374 matches

Go to advanced search

by faisal
Sun May 27, 2018 11:55 am
Forum: Small Change Requests
Topic: Check for NULL ptr in HAL_PAL
Replies: 3
Views: 2281

Re: Check for NULL ptr in HAL_PAL

The dereferencing is done mainly in the hal_pal_lld.h macro. I'm thinking we could do a null ptr check at the hal_pal layer before calling the LLD driver routines/macros.
by faisal
Sun May 27, 2018 11:41 am
Forum: Bug Reports
Topic: Small default stacks for idle and usb_pump threads Topic is solved
Replies: 10
Views: 5432

Re: Small default stacks for idle and usb_pump threads Topic is solved

Giovanni wrote:Hi,

USB pump has been removed, I think this is no more relevant.

Giovanni


Is there no issue with using CH_DBG_* options? Is any additional stack size required by the idle thread taken into account already?
by faisal
Sun May 27, 2018 5:02 am
Forum: Development and Feedback
Topic: Clang/LLVM
Replies: 35
Views: 22182

Re: Clang/LLVM

Have anyone been able to give Clang/LLVM a try yet? I'm looking forward to being able to use the various clang tools out there (static analyzer, tidy, formatter, etc ..).
by faisal
Tue May 22, 2018 8:56 pm
Forum: Small Change Requests
Topic: Check for NULL ptr in HAL_PAL
Replies: 3
Views: 2281

Check for NULL ptr in HAL_PAL

The PAL driver dereferences a pointer to a peripheral address (i.e. GPIOA->ODR). The 'port' pointer should be checked for a NULL pointer using chDbgCheck() (so that it can be disabled for release builds).
by faisal
Sun May 06, 2018 4:08 pm
Forum: Small Change Requests
Topic: STM32 UART LLD, character match interrupt Topic is solved
Replies: 13
Views: 10359

Re: STM32 UART LLD, character match interrupt Topic is solved

Giovanni wrote:Hi,

Committed in trunk.

Giovanni


Can we get it backported to 18.2?
by faisal
Sat May 05, 2018 5:31 am
Forum: ChibiOS/RT
Topic: change thread priority from a timer callback
Replies: 17
Views: 9319

Re: change thread priority from a timer callback

The SPI bus threads are normally the highest priority threads in ArduPilot. On some flight boards these threads can be quite busy. For example, a Cube 2.1 has 3 SPI IMUs, and two of them can run at 8k transactions per second (with each transaction transferring 14 bytes of data). The 4th runs at 1k ...
by faisal
Tue Apr 24, 2018 6:24 pm
Forum: Bug Reports
Topic: -fsingle-precision-constant breaks C++ standard library Topic is solved
Replies: 7
Views: 3595

Re: -fsingle-precision-constant breaks C++ standard library Topic is solved

I also think it should be defined by the user.

Fyi, some stm32f7s and the H7 I believe have hardware double float support... so there's that.
by faisal
Mon Apr 23, 2018 1:42 pm
Forum: ChibiOS/RT
Topic: Strange behavior of mailboxes
Replies: 6
Views: 3629

Re: Strange behavior of mailboxes

Can you try increasing the relative priority of the transmitter or receiver thread?
by faisal
Sun Apr 22, 2018 8:55 am
Forum: Small Change Requests
Topic: Expose CFGR2 in STM32/LLD/ADCv3 ADCConversionGroup Struct Topic is solved
Replies: 3
Views: 3065

Re: Expose CFGR2 in STM32/LLD/ADCv3 ADCConversionGroup Struct Topic is solved

This has been lingering for over a month. Any comments on whether or not this will be considered for inclusion in HAL?
by faisal
Sun Apr 22, 2018 8:53 am
Forum: Small Change Requests
Topic: STM32 UART LLD, character match interrupt Topic is solved
Replies: 13
Views: 10359

Re: STM32 UART LLD, character match interrupt Topic is solved

Any feedback on the patch, or comments on whether this will be supported in HAL?

Go to advanced search