Search found 7 matches

by Stapelzeiger
Sun Oct 11, 2020 8:58 pm
Forum: Development and Feedback
Topic: [DEV] STM32G4xx support
Replies: 100
Views: 116588

Re: [DEV] STM32G4xx support

Hi,
what is the status of the FDCAN driver? It looks like @Shevchenko last fix is not in the repo.
by Stapelzeiger
Mon Apr 06, 2015 7:15 pm
Forum: ChibiOS/RT
Topic: chevents: listener flags clearing (bug)
Replies: 10
Views: 8833

Re: chevents: listener flags clearing (bug)

It might be working as intended, but this intention is documented nowhere

As I see it the gain would be a more consistent and intuitive API. (less surprises)
The cost is one word size increase for the listener. Like I perceive the desing goals of ChibiOS/RT the change would be worth the cost, but ...
by Stapelzeiger
Mon Apr 06, 2015 5:52 pm
Forum: ChibiOS/RT
Topic: chevents: listener flags clearing (bug)
Replies: 10
Views: 8833

Re: chevents: listener flags clearing (bug)

you could create a copy inside the listener. (what i suggested in my comment above to keep the existing flags API)
by Stapelzeiger
Mon Apr 06, 2015 5:13 pm
Forum: ChibiOS/RT
Topic: chevents: listener flags clearing (bug)
Replies: 10
Views: 8833

Re: chevents: listener flags clearing (bug)

Consider that events and event flags are two distinct things. It is possible to work with events without having to use event flags.
I got that.
why should chEvtGetAndClearEvents() clear also flags?
I don't want the function to actually go and clear flags in the listeners. This would not respect ...
by Stapelzeiger
Mon Apr 06, 2015 4:39 pm
Forum: ChibiOS/RT
Topic: chevents: listener flags clearing (bug)
Replies: 10
Views: 8833

Re: chevents: listener flags clearing (bug)

1) doesn't really clear the event (yes, sure it clears the event in the thread, but this isn't really anything useful).
2) does what it says.

The thing is that when working with event masks (eventmask_t) the function chEvtGetAndClearEvents doesn't clear the event at the listener. So you have to ...
by Stapelzeiger
Mon Apr 06, 2015 2:20 pm
Forum: ChibiOS/RT
Topic: chevents: listener flags clearing (bug)
Replies: 10
Views: 8833

Re: chevents: listener flags clearing (bug)

The point is that the function chEvtGetAndClearEvents doesn't do what it says i.e. clear the event, since it is retriggered as soon as the source broadcasts anything. This is very unintuitive and not documented.

For the implementation details: I see that the thread can't enumerate the listeners ...
by Stapelzeiger
Mon Apr 06, 2015 1:54 pm
Forum: ChibiOS/RT
Topic: chevents: listener flags clearing (bug)
Replies: 10
Views: 8833

chevents: listener flags clearing (bug)

Hi,

When using chEvtBroadcastFlags the event flags (el_flags) of a event_listener_t are not cleared automatically when the event is triggered.
The problem is that this results in incorrect behaviour for functions that work with eventmasks, like chEvtGetAndClearEvents. This function can actually ...