Search found 21 matches

by Bogdan
Sun May 03, 2020 4:24 pm
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi Giovanni,

I have attached one more variant with a switchable pool range check during freeing memory.

Thanks,
by Bogdan
Sun May 03, 2020 1:24 pm
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi Giovanni,

You moved constant data (queue_sz, item_sz, objbuf) into a variable, those are never modified after creating the object. If it is just for that extra check then it looks overkill, it takes RAM and slows the function at runtime.

Yes, this move was made to add this check in the ...
by Bogdan
Sat May 02, 2020 10:38 pm
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi,

I have updated some return codes to be able to pass tests.
Also, I have modified osMailQId to be able to check the situation when the code of Business Logic returns the address in osMailFree that was not allocated before from Mail. Was required by the test scenario:
uint32_t val = 0;
ASSERT ...
by Bogdan
Thu Apr 30, 2020 12:56 pm
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi,

Also During Validating Semaphores, I faced with the issue.
In the scenario below, we have an incorrect behavior of chSemReset.

chSemObjectInit(sem, 0x7FFFFFFF); // 0x7FFFFFFF (2,147,483,647) -is the maximum possible positive value for int32_t
chSemReset(sem, 0);

The chSemReset(sem, 0); in ...
by Bogdan
Thu Apr 30, 2020 12:39 pm
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi Giovanni,

I have collected changes for Mails, Timers, Pools.
In attachment, you can find them.

Thanks,
by Bogdan
Sun Apr 26, 2020 11:10 am
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi Giovanni,

In the attachment, you can find a patch for Pools API on the master branch.
Here I have the same problem with a test that checks that address that we are returning into the pool, that it was gotten from this pool.
uint32_t val = 0;
ASSERT_TRUE (osPoolFree (MemPool_Id, &val ...
by Bogdan
Sat Apr 25, 2020 10:03 pm
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi Giovanni,

I also have updated Timers and validated them.
Patch for current master in the attachement.

CMSIS-RTOS Test Suite Apr 25 2020 23:27:14

TEST 01: TC_TimerOneShot PASSED
TEST 02: TC_TimerPeriodic PASSED
TEST 03: TC_TimerParam PASSED
TEST 04: TC_TimerInterrupts PASSED

Test Summary: 4 ...
by Bogdan
Sat Apr 25, 2020 7:22 pm
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi Giovanni,

I have updated files and validated them with Keil Validations scripts. Files you can find in attachment.

Only one case from TC_MailParam scenario was skipped.
uint32_t val = 0;
ASSERT_TRUE (osMailFree (MailQ_Id, &val) == osErrorValue);
I didn't find how to check that return for ...
by Bogdan
Sun Apr 19, 2020 10:35 am
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi Giovanni,

I appreciate for your work. I will check your changes. Sorry for not answering for a long time.

Thanks.
by Bogdan
Tue Feb 18, 2020 1:47 pm
Forum: Small Change Requests
Topic: cmsis_os add MailQueue
Replies: 18
Views: 16044

Re: cmsis_os add MailQueue

Hi,

In the repository, I've found only one project that uses a cmsis_os API. It is "os\demos\STM32\CMSIS-STM32F407-DISCOVERY\main.c" and it is very simple uses osThreadCreate and osDelay APIs.
I will try to write some test suite for this file. When it will be ready, I will provide the patch in this ...