ChibiOS Free Embedded RTOS

Giovanni wrote:Hi,

I removed the syscalls_cpp.* files (in trunk), now the wrapper includes the normal syscalls.c file. Could you retest the current wrapper? my demo is not failing but something could still be missing.

Giovanni

When using virtual functions in C++, __cxa_pure_virtual() is needed.

Removed the duplicate functions from syscalls_cpp.cpp.

I wonder if there's a way to tell the compiler "this pointer is correctly aligned" other than making it a uint32_t* (or stkalign_t* or ...). The only way I see to do this is by declaring it as uint32_t* and cast it down to uint8_t* if byte-wise operations are needed. Actually, there is __...

I wonder if there's a way to tell the compiler "this pointer is correctly aligned" other than making it a uint32_t* (or stkalign_t* or ...). The only way I see to do this is by declaring it as uint32_t* and cast it down to uint8_t* if byte-wise operations are needed. Actually, there is __...

Hi, In general OK but the use of memcpy() would impact performance in some pretty critical places, see USB code, that code implicitly relies on pointers being correctly aligned. Giovanni GCC is smart enough to replace calls to memcpy() with other copy operations when appropriate with -O2. I looked ...

Some thoughts on how to prevent unaligned memory access: Perform pointer arithmetic on maximum alignment Instead of uint32_t * x = (uint32_t)((uint8_t *)y + n) do uint32_t * x = (uint32_t *)y + n / sizeof (uint32_t) So we guarantee that x has the correct alignment. Of course we have to ensure that (...

Using GCC, I have enabled the "-Wcast-align" warnings enabled. Unfortunately, 1. the ChibiOS code performs such casting operations which increase the required alignment and 2. the ChibiOS Makefile structure does not easily allow to disable warnings for ChibiOS source files while keeping th...

Any updates on this?

Giovanni wrote:I could update the headers but there is the risk to break something else.

Giovanni

I think it would be easier to revert the regression fix that somehow slipped back to ChibiOS 19. (https://github.com/ChibiOS/ChibiOS/comm ... 83b60f6689)

Sorry to necrobump this, but the commit containing said fix ( dda9f7b8d4 on GitHub ) seems to do more that the patch submitted by piers and breaks the build. To be concrete, the file now uses the defines ADC_ISR_ADRDY instead of ADC_ISR_ADRD, ADC_IER_OVRIE instead of ADC_IER_OVR and ADC_IER_AWD1IE i...