ChibiOS Free Embedded RTOS

I adjusted some comments.

It has been a long process but this should be about final, could everybody give barthess and me some feedback about this driver? there is something else that could be done on it?

Giovanni

Hi,

I wrote a small guideline about coding style and documentation rules: http://www.chibios.org/dokuwiki/doku.ph ... tyle_guide

It is not everything but will be expanded with time.

Giovanni

I will be adding a measurement subsystem next week, that could be used for that purpose. It will be able to measure the worst/best/last case of any portion of code with clock resolution and few clocks error.

Changes to the plugin could follow.

Giovanni

Its good to have a mirror anyway, thanks.

Giovanni

It could be a stack alignment problem, I have to look into this. Can you create a test case?

Giovanni

First you write code and it is ugly and doesn't work. Then you write code and it is ugly but works. After a while you write code and it is beautiful and it works. Finally you write code and it is so beautiful that it doesn't matter if it works. Jokes apart, I have doubts on the CR2 handling. You ini...

Hi,

It has been merged on trunk now, so get latest.

Giovanni

Hi, The word size is always 8bit, it has to be in that protocol and the SPI must be configured that way from the application. I merged the code but had to do changes, there were warning, also, I don't want a dependence between the HAL and "various" so I included the CRC7 code in the driver...

Ok, go ahead (I saw you already branched anyway ).

After I2C and this one it is 2.4.0 time.

Giovanni

It is planned but I don't have hardware to test it, could you help with this?

Giovanni