[QUALITY] The MISRA topic

[steved]

First side effect.....

Looks like today's changes have broken chschd.c.

A simple:
chThdSleepMilliseconds(500);

causes a 'wakeup' error when the timer expires.

Reverting to the file of 12th January fixes it.

[Giovanni]

Hi,

I am unable to reproduce, it executes the test suite correctly, are you able to understand where it goes wrong? is that an assertion?

Edit: Nevermind, I found the problem, fixed on repository, thanks.

Giovanni

[Giovanni]

Personally I would prefer the code to be clean and readable to meeting some draconian rules like "macros must be surrounded by parentheses". It seems like many of the MISRA rules may be more of a burden and cost to readability than is worth the benefit of being "MISRA compliant" or getting some actual robustness. But, there may be some useful warnings to take to heart or techniques that are good ... maybe those are the exception however.

I agree, I am trying to balance code readability with MISRAs, I made global waivers for the most dumb/annoying rules and added few /*lint ...*/ comments in the code, most changes are to the #if conditions and complex expressions split up, so far it is not too bad and it helped me finding a couple of minor issues like a "|" instead of "||" in an #if, no real bugs anyway.

More importantly, no impact on code efficiency so far.

Giovanni

[Giovanni]

I just finished the MISRA 2012 pass on the RT portable kernel. The testbuild script now performs a MISRA check on all the defined configurations and stops if something is found in any of them.

Giovanni

[Giovanni]

Hi,

The portable HAL is now compliant as well.

Giovanni