hal_files.h error in fileStreamGetSize: ')' at wrong place Topic is solved

[mumme]

Hi!

I'm using 19.1.3, but it is the same in master.

Compile error In macro fileStreamGetSize:

Code: Select all

../../../ChibiOS-git/os/hal/include/hal_files.h:210:40: error: too few arguments to function 'dtcFile->vmt->getsize'
 #define fileStreamGetSize(ip, offset) ((ip)->vmt->getsize(ip), offset)
                                        ^

I expect it to be: (moved parenthesis)

Code: Select all

 #define fileStreamGetSize(ip, offset) ((ip)->vmt->getsize(ip, offset))

Is this correct?
Seems to work fine when i move the parenthesis.

[Giovanni]

Thanks, that interface is not yet used, will fix it.

Giovanni

[Giovanni]

Fixed as bug #1040.

Giovanni

[faisal]

Hi!

I'm using 19.1.3, but it is the same in master.

Compile error In macro fileStreamGetSize:

Code: Select all

../../../ChibiOS-git/os/hal/include/hal_files.h:210:40: error: too few arguments to function 'dtcFile->vmt->getsize'
 #define fileStreamGetSize(ip, offset) ((ip)->vmt->getsize(ip), offset)
                                        ^

I expect it to be: (moved parenthesis)

Code: Select all

 #define fileStreamGetSize(ip, offset) ((ip)->vmt->getsize(ip, offset))

Is this correct?
Seems to work fine when i move the parenthesis.

Are you using this interface? Care to share how you're using it?