STM32L4x3 GPIO Bank D and E enable mask not correct Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
Jeansburger
Posts: 2
Joined: Wed Jul 28, 2021 3:25 pm
Been thanked: 1 time

STM32L4x3 GPIO Bank D and E enable mask not correct

Postby Jeansburger » Wed Jul 28, 2021 3:36 pm

The STM32L4x3 registry has the STM32_HAS_GPIOD and the STM32_HAS_GPIOE set to TRUE however the enable mask for the GPIO is not set correctly

Code: Select all

/os/hal/ports/STM32/STM32L4xx/stm32_registry.h

The STM32_GPIO_EN_MASK is set to

Code: Select all

#define STM32_GPIO_EN_MASK                  (RCC_AHB2ENR_GPIOAEN |          \
                                             RCC_AHB2ENR_GPIOBEN |          \
                                             RCC_AHB2ENR_GPIOCEN |          \
                                             RCC_AHB2ENR_GPIOHEN)


But it should be

Code: Select all

#define STM32_GPIO_EN_MASK                  (RCC_AHB2ENR_GPIOAEN |          \
                                             RCC_AHB2ENR_GPIOBEN |          \
                                             RCC_AHB2ENR_GPIOCEN |          \
                                             RCC_AHB2ENR_GPIODEN |          \
                                             RCC_AHB2ENR_GPIOEEN |          \
                                             RCC_AHB2ENR_GPIOHEN)

User avatar
Giovanni
Site Admin
Posts: 13721
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 916 times
Been thanked: 779 times
Contact:

Re: STM32L4x3 GPIO Bank D and E enable mask not correct

Postby Giovanni » Wed Jul 28, 2021 8:20 pm

Hi,

Thanks for finding.

Giovanni

Jeansburger
Posts: 2
Joined: Wed Jul 28, 2021 3:25 pm
Been thanked: 1 time

Re: STM32L4x3 GPIO Bank D and E enable mask not correct

Postby Jeansburger » Sat Aug 14, 2021 5:59 am

Any status on when this change would be implemented into one of the supported versions?

I would contribute the change but I'm unsure how to either make a patch or the equivalent of a PR to the repo to order to fix this. It would fix the registry I found but also any other STM32 registries I found a similar bug in.

Let me know,
~JB

User avatar
Giovanni
Site Admin
Posts: 13721
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 916 times
Been thanked: 779 times
Contact:

Re: STM32L4x3 GPIO Bank D and E enable mask not correct

Postby Giovanni » Sat Aug 14, 2021 6:16 am

Hi,

This will be fixed in next release and in all active branches.

Please specify all registries where this problem is present.

Giovanni

User avatar
Giovanni
Site Admin
Posts: 13721
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 916 times
Been thanked: 779 times
Contact:

Re: STM32L4x3 GPIO Bank D and E enable mask not correct  Topic is solved

Postby Giovanni » Tue Aug 17, 2021 2:10 pm

Hi,

Fixed as bug #1174.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 7 guests