Stable 21.11.x SPI bug Topic is solved

[alexblack]

Hello.
In current stable version there are an errors in spi_lld V2 driver:

Code: Select all

compiling hal_spi_lld.c...
..\..\!ufg_pp_new_2021\lib\ChibiOS\os\hal\ports\STM32\LLD\SPIv2\hal_spi_lld.c(146): warning:  #223-D: function "_spi_isr_half_code" declared implicitly
        _spi_isr_half_code(spip);
..\..\!ufg_pp_new_2021\lib\ChibiOS\os\hal\ports\STM32\LLD\SPIv2\hal_spi_lld.c(150): warning:  #223-D: function "_spi_isr_full_code" declared implicitly
        _spi_isr_full_code(spip);
..\..\!ufg_pp_new_2021\lib\ChibiOS\os\hal\ports\STM32\LLD\SPIv2\hal_spi_lld.c(160): warning:  #223-D: function "_spi_isr_code" declared implicitly
      _spi_isr_code(spip);
..\..\!ufg_pp_new_2021\lib\ChibiOS\os\hal\ports\STM32\LLD\SPIv2\hal_spi_lld.c(315): error:  #147: declaration is incompatible with "msg_t spi_lld_start(SPIDriver *)"  (declared at line 545 of "..\lib\ChibiOS\os\hal\ports\STM32\LLD\SPIv2\hal_spi_v2_lld.h")
  void spi_lld_start(SPIDriver *spip) {
..\..\!ufg_pp_new_2021\lib\ChibiOS\os\hal\ports\STM32\LLD\SPIv2\hal_spi_lld.c(560): error:  #147: declaration is incompatible with "msg_t spi_lld_ignore(SPIDriver *, size_t)"  (declared at line 551 of "..\lib\ChibiOS\os\hal\ports\STM32\LLD\SPIv2\hal_spi_v2_lld.h")


The first two errors are because in hal_spi_v2.h file used two underscores instead of one:

Code: Select all

428 #define __spi_isr_half_code(spip) {                                         \
429   if ((spip)->config->data_cb) {                                            \
430     (spip)->config->data_cb(spip);                                          \
431   }                                                                         \
432 }


The other errors I not understood yet.

[alexblack]

Sorry.
I was found the problem: I ported the old project and was include the file hap_spi_lld.c instead of the new hal_spi_v2_lld.c.
I do not understand why there are two files on LLD folder and how I must proper select the one. I do not use ChibiStudio and make files (KEIL compiller).

[Giovanni]

No problems, I will remove the old one at some point.

Giovanni