Mismatch in hal_serial.h Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
anotheruserofchibios
Posts: 2
Joined: Wed Aug 24, 2022 3:52 pm
Been thanked: 2 times

Mismatch in hal_serial.h  Topic is solved

Postby anotheruserofchibios » Wed Aug 24, 2022 4:23 pm

Hello,

On the master branch (actually from the original commit) it seems there is an extra argument in the call to iqReadI() from the macro sdReadI(), i.e. there should not be a timeout, so rather:

Code: Select all

#define sdReadI(sdp, b, n) iqReadI(&(sdp)->iqueue, b, n)


Also I am wondering if the documentation of sdReadI() & sdWriteI() is correct about being blocking read/write since their iqReadI() & oqWriteI() counterparts claim they are non-blocking read/write.

User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: Mismatch in hal_serial.h

Postby Giovanni » Wed Aug 24, 2022 8:31 pm

Hi,

Probably the oldest bug ever found :-)

I will look into the documentation mismatch, "i" functions cannot be blocking obviously,

Giovanni

User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: Mismatch in hal_serial.h

Postby Giovanni » Sun Sep 18, 2022 10:49 am

Hi,

Fixed as bug #1236.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 14 guests