STM32 OTGv1 GCCFG initialization bug. Topic is solved

[JasonRen]

https://github.com/jiaxin96/ChibiOS/blo ... _lld.c#L43,

Code: Select all

#if defined(BOARD_OTG_NOVBUSSENS)
#define GCCFG_INIT_VALUE        (GCCFG_NOVBUSSENS | GCCFG_VBUSASEN |        \
                                 GCCFG_VBUSBSEN | GCCFG_PWRDWN)
#else
#define GCCFG_INIT_VALUE        (GCCFG_VBUSASEN | GCCFG_VBUSBSEN |          \
                                 GCCFG_PWRDWN)
#endif

When VBUSSENS is disabled, the initialization parameters are wrong, which leads to some USB pins not working properly as GPIO. It should be changed to the following definition:

Code: Select all

#if defined(BOARD_OTG_NOVBUSSENS)
#define GCCFG_INIT_VALUE        (GCCFG_NOVBUSSENS | GCCFG_PWRDWN)
#else
#define GCCFG_INIT_VALUE        (GCCFG_VBUSASEN | GCCFG_VBUSBSEN |          \
                                 GCCFG_PWRDWN)
#endif

[Giovanni]

Hi,

Change committed, thanks.

Giovanni