copy paste typo in SPIV3 (H7) driver. Topic is solved

[alex31]

Hello,

On stm32H7, SPI is connected to BDMA, it's managed by the driver, but there is copy paste typo in a dbgAssert check, so the app run fine without assert, but fail when they are in use.

Here is the patch for ChibiOS 21.11.x current.

Code: Select all

diff --git a/os/hal/ports/STM32/LLD/SPIv3/hal_spi_lld.c b/os/hal/ports/STM32/LLD/SPIv3/hal_spi_lld.c
index f0ef28d6d..14dcadf37 100644
--- a/os/hal/ports/STM32/LLD/SPIv3/hal_spi_lld.c
+++ b/os/hal/ports/STM32/LLD/SPIv3/hal_spi_lld.c
@@ -599,12 +599,12 @@ void spi_lld_start(SPIDriver *spip) {
                                       STM32_SPI_SPI6_IRQ_PRIORITY,
                                       (stm32_dmaisr_t)spi_lld_serve_bdma_rx_interrupt,
                                       (void *)spip);
-      osalDbgAssert(spip->rx.dma != NULL, "unable to allocate stream");
+      osalDbgAssert(spip->rx.bdma != NULL, "unable to allocate stream");
       spip->tx.bdma = bdmaStreamAllocI(STM32_SPI_SPI6_TX_BDMA_STREAM,
                                       STM32_SPI_SPI6_IRQ_PRIORITY,
                                       (stm32_dmaisr_t)spi_lld_serve_bdma_tx_interrupt,
                                       (void *)spip);
-      osalDbgAssert(spip->tx.dma != NULL, "unable to allocate stream");
+      osalDbgAssert(spip->tx.bdma != NULL, "unable to allocate stream");
       rccEnableSPI6(true);
       bdmaSetRequestSource(spip->rx.bdma, STM32_DMAMUX2_SPI6_RX);
       bdmaSetRequestSource(spip->tx.bdma, STM32_DMAMUX2_SPI6_TX);


Alexandre

[alex31]

Note that the problem is in the V1 driver, not in the more recent V2 driver.
A.

[Giovanni]

Hi,

Fixed in trunk.

Any reason for using v1?

Giovanni

[alex31]

Hi,

Any reason for using v1?

Don't know yet
Have to ask other dev that made the choice, but Ardupilot and Paparazzi are using V1 for accessing invensense IMU at high rate
Will try to revert to v2 in Paparazzi to see if it breaks things or not.

Alexandre