RTC module loses day of week when converting

This forum is dedicated to feedback, discussions about ongoing or future developments, ideas and suggestions regarding the ChibiOS projects are welcome. This forum is NOT for support.
Post Reply
User avatar
woodstock
Posts: 7
Joined: Wed Nov 04, 2015 7:06 am

RTC module loses day of week when converting

Post by woodstock »

Hi,

First up I'd just like to say that I'm pretty new to ChibiOS (and RTOS' in general), but so far I think it's great!

I have noticed that the function to convert between RTCDateTime and tm structs (rtcConvertDateTimeToStructTm) does not convert the weekday field.
I have attached a patch file to fix this.

For future reference, what is the best way to make contributions?

woodstock
Attachments
patch.diff.zip
(402 Bytes) Downloaded 339 times
User avatar
Giovanni
Site Admin
Posts: 14893
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 997 times

Re: RTC module loses day of week when converting

Post by Giovanni »

Hi,

Thanks for the patch, best way is to add a ticket to the tracker on SF, this way the change is not lost in the noise for sure.

Giovanni
User avatar
woodstock
Posts: 7
Joined: Wed Nov 04, 2015 7:06 am

Re: RTC module loses day of week when converting

Post by woodstock »

Thanks!
Post Reply