Add SHA224 and MD5 to hal_crypto

Use this forum for requesting small changes in ChibiOS. Large changes should be discussed in the development forum. This forum is NOT for support.
Post Reply
faisal
Posts: 382
Joined: Wed Jul 19, 2017 12:44 am
Has thanked: 45 times
Been thanked: 62 times

Add SHA224 and MD5 to hal_crypto

Post by faisal »

STM32 supports these, but are not in the high level hal_crypto.h file, nor does the LLD implementation have them.
User avatar
Giovanni
Site Admin
Posts: 14892
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 996 times

Re: Add SHA224 and MD5 to hal_crypto

Post by Giovanni »

Hi,

MD5 was left out on purpose, it is unsafe and should not be used.

Giovanni
faisal
Posts: 382
Joined: Wed Jul 19, 2017 12:44 am
Has thanked: 45 times
Been thanked: 62 times

Re: Add SHA224 and MD5 to hal_crypto

Post by faisal »

Giovanni wrote:Hi,

MD5 was left out on purpose, it is unsafe and should not be used.

Giovanni


MD5 is still widely used, and you may not have a choice if working with an external system. Also, depending on your threat model, it's not completely terrible to use. Makes sense to support it if the hardware does IMHO.
Post Reply