USB CDC + NIL osalThreadDequeueAllI assertion fail

Discussions and support about ChibiOS/HAL, the MCU Hardware Abstraction Layer.
ulikoehler
Posts: 71
Joined: Tue Mar 17, 2015 2:32 am
Been thanked: 3 times

Re: USB CDC + NIL osalThreadDequeueAllI assertion fail

Post by ulikoehler »

Sorry for the late reply!

Yes, I think logically this fixes the bug. I think your fix is simpler than mine (and likely results in a smaller code size) and therefore should be used.

I'll try it out with my firmware in the next days and I'll let you know when I have any results.

Best regards, Uli
ulikoehler
Posts: 71
Joined: Tue Mar 17, 2015 2:32 am
Been thanked: 3 times

Re: USB CDC + NIL osalThreadDequeueAllI assertion fail

Post by ulikoehler »

Sorry again for the delay. I didn't have access to the USB adapter hardware before today.

As far as I can tell, the error doesn't occur any more with your changed source code on my hardware. I also think that your patch logically eliminates the bug, so +1 from me for applying that fix.

Best regards,
Uli
User avatar
Giovanni
Site Admin
Posts: 14893
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 997 times

Re: USB CDC + NIL osalThreadDequeueAllI assertion fail

Post by Giovanni »

Thanks, marking as fixed then.

Giovanni
Post Reply