Page 8 of 10

Re: STM32WB55 support

Posted: Fri Jan 08, 2021 1:24 pm
by akscram
Giovanni and Bob,

I've been continue polishing the STM32WB support and attached a new portion of patches. They are suppose to be applied on top of the patches from the previous tarball (STM32WBxx-b4186f.zip). They are ready for review.

Summary of commit messages:

Code: Select all

* 0003 STM32WB: fix style errors

* 0004 STM32WB: update ADC1 in ADCv3

  * Add STM32_ADC_ADC1_PRESC
  * Remove ADC_DMA_MDMA as not supported
  * Change the default value of STM32_ADCSEL to STM32_ADCSEL_SYSCLK

* 0005 STM32WB: update mcuconf STM32WB55XX template

  * Removed STM32_MSISRANGE and STM32_SWPMI1SEL as not supported
  * Updated STM32_HSI16_ENABLED, STM32_HSI48_ENABLED, STM32_LSE_ENABLED
    and STM32_SW to their default values according to STM32WBxx/hal_lld.h
  * Added STM32_C2HPRE and STM32_SHDHPRE parameters
  * Fixed STM32_IRQ_EXTI17_PRIORITY parameters name
  * Added STM32_IRQ_EXTI18_PRIORITY
  * Updated ADC parameters:
    * Removed STM32_ADC_DUAL_MODE as not supported
    * Added STM32_ADC_ADC1_IRQ_PRIORITY and removed ADC12 and ADC3
    * Added STM32_ADC_ADC1_CLOCK_MODE and removed ADC123
    * Added STM32_ADC_ADC1_PRESC and removed ADC123
  * Regenerated STM32WB55_MCUCONF mcuconf files (TODO USB board)

* 0006 STM32WB: update stm32wbxx board schema

  * Return LSEBypass and remove unsupported HSEBypass


Best regards,
Ilya.

Re: STM32WB55 support

Posted: Sun Jan 10, 2021 12:57 am
by FXCoder
Hi Ilya,
I get a bad zip format from the attachment.
--
Bob

Re: STM32WB55 support

Posted: Sun Jan 10, 2021 9:41 am
by akscram
Hi Bob,

Thank you for taking a look. I've tried to download and open them, however got an error too. I made a new tarball with both sets of patches and attached it. Can you please try one more time?

Best regards,
Ilya.

Re: STM32WB55 support

Posted: Tue Jan 12, 2021 9:43 am
by Giovanni
Hi,

Patches committed. I modified the order of checks for USB addresses, USB_BASE in WB headers is spurious and will probably be removed in newer header versions. It must be a leftover of some other device.

Giovanni

Re: STM32WB55 support

Posted: Sat Jan 16, 2021 9:44 pm
by akscram
Hi Giovanni,

Thank you for accepting those patches! I've attached another portion of clean up patches which are ready for review. Here is their commit message summary:

Code: Select all

* 0001 STM32WB: update board templates

  * Update ST_NUCLEO48_WB55CG_USB
    * BUTTON is located at GPIOA/10
    * Regenerate board and mcuconf files

  * Cosmetic changes:
    * Use tabs instead of a mixture of spaces and tabs in XMLs
    * Put port IDs at the first place
    * Organize each port parameter on a separate line

* 0002 STM32WB: Add USB_CDC for STM32WB55RC Nucleo USB

* 0003 STM32WB: remove hal_efl_lld previous copied from STM32L4xx


Best regards,
Ilya.

Re: STM32WB55 support

Posted: Sun Jan 17, 2021 5:37 am
by Giovanni
Hi,

Please no tabs anywhere, convert everything to spaces.

Giovanni

Re: STM32WB55 support

Posted: Mon Jan 18, 2021 12:54 am
by akscram
Hi,

I've moved from using tabs in XML files to spaces, you can find updated previous patches in the attachment.

Best regards,
Ilya.

Re: STM32WB55 support

Posted: Mon Jan 18, 2021 12:33 pm
by akscram
Hi Bob,

However the WB55 differences also extend to PLLSAI1N_VALUE which can be 4 and so below the limit currently used in stm32_pllsai1.inc.


I was trying to open your patch attached in pllsail.inc.zip, however I was not able to open it because of an unpacking error. Could you please reupload it?

Best regards,
Ilya.

Re: STM32WB55 support

Posted: Mon Jan 18, 2021 1:11 pm
by FXCoder
Hi Ilya,
See if this one opens OK.
--
Bob

Re: STM32WB55 support

Posted: Tue Jan 19, 2021 12:41 pm
by Giovanni
The problem with attachments should be resolved now, it was caused by issue caused by the phpbb migration. All previous attachments should be restored.

Giovanni