chprintf inline warning
Posted: Mon Nov 09, 2015 12:11 am
I'm not sure if this issue is specific to GCC or not (although I do know it is the case with some other compilers), but variadic functions cannot be inlined (such as chprintf).
Using the warning option -Winline, I get the following warning message:
It therefore seems that it might be unnecessary (or even confusing) to include the inline keyword there, if I am correct.
Anyway, it's not a huge issue, but I just thought that I'd point it out anyway.
Using the warning option -Winline, I get the following warning message:
Code: Select all
/os/hal/lib/streams/chprintf.h:69:19: warning: function 'chprintf' can never be inlined because it uses variable argument lists [-Winline]It therefore seems that it might be unnecessary (or even confusing) to include the inline keyword there, if I am correct.
Anyway, it's not a huge issue, but I just thought that I'd point it out anyway.