Potential bug in shell_cmd.c

ChibiOS public support forum for all topics not covered by a specific support forum.

Moderators: RoccoMarco, lbednarz, tfAteba

Post Reply
User avatar
woodstock
Posts: 7
Joined: Wed Nov 04, 2015 7:06 am

Potential bug in shell_cmd.c

Post by woodstock »

Perhaps I have messed up somewhere with my versioning and have got out of sync, but I seem to have a problem with os/various/shell/shell_cmd.c file...

On line 165 the following code is used, referring to a thread variable that I believe is no longer used(??).

Code: Select all

uint32_t stklimit = (uint32_t)tp->stklimit;


I believe this should instead be:

Code: Select all

uint32_t stklimit = (uint32_t)tp->wabase;


My apologies if I have missed something – I have not looked at ChibiOS since v3.0.x and am only just migrating to ChibiOS 16 now.
User avatar
Giovanni
Site Admin
Posts: 14893
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 997 times

Re: Potential bug in shell_cmd.c

Post by Giovanni »

Hi,

That variable changed name in the trunk code, 16.1.4 still uses the old name.

I will verify.

Giovanni
Post Reply