Page 1 of 1

hal_stm32_ltdc patch

Posted: Fri Jul 08, 2016 8:25 pm
by wdouglass
In order to get hal_stm32_ltdc to build with my new project, i need to apply the following patch. thought i'd share!

Is this where I should be submitting patches?

Thanks,
Woody

Code: Select all

--- a/community/os/hal/ports/STM32/LLD/LTDCv1/hal_stm32_ltdc.c   2016-04-30 02:47:37.000000000 -0400
+++ b/community/os/hal/ports/STM32/LLD/LTDCv1/hal_stm32_ltdc.c   2016-07-08 15:21:40.187610167 -0400
@@ -173,7 +173,7 @@
     if (ltdcp->thread != NULL) {
       tp = ltdcp->thread;
       ltdcp->thread = NULL;
-      tp->u.rdymsg = MSG_OK;
+      tp->p_u.rdymsg = MSG_OK;
       chSchReadyI(tp);
     }
 #endif  /* LTDC_USE_WAIT */

Re: hal_stm32_ltdc patch

Posted: Fri Jul 08, 2016 11:38 pm
by Giovanni
Hi,

You can post patches here or make a pull request on the community repository.

Note that your patch seems to be meant for ChibiOS RT 3.x stable, the code on the repository is correct for ChibiOS RT 4.x currently on the trunk and next to be released. I am not sure it should be accepted, you will be fine after updating to 4.x.

Giovanni

Re: hal_stm32_ltdc patch

Posted: Mon Jul 11, 2016 1:04 pm
by wdouglass
Giovanni,

I'll take a look at 4.x; i've been using 3 stable for a bit now.

If i have patches in the future, i'll rebase against the head of the repo and make a pull request.

Thanks for Chibios and all of your great work!

-Woody