UART driver ISR convenience macro bug
Posted: Sun Oct 16, 2016 8:27 pm
Hi all,
In creating a UART driver for my MSP430X port of ChibiOS, I've run into the following problem.
In the helper macro for calling the RX complete ISR, _uart_rx_complete_isr_code, there is a call to a function uart_enter_rx_idle_loop. This is a local (static) method of the STM32 UART port.
Obviously I can still get the effect I want in any of several ways (define the method, don't use the helper macro), but this seems like a bug nonetheless. Either the ISR macro shouldn't call that method, or the method should be an exported lld method like uart_lld_init.
As always, if you disagree I'm very open to hearing why I'm wrong.
Thanks!
In creating a UART driver for my MSP430X port of ChibiOS, I've run into the following problem.
In the helper macro for calling the RX complete ISR, _uart_rx_complete_isr_code, there is a call to a function uart_enter_rx_idle_loop. This is a local (static) method of the STM32 UART port.
Obviously I can still get the effect I want in any of several ways (define the method, don't use the helper macro), but this seems like a bug nonetheless. Either the ISR macro shouldn't call that method, or the method should be an exported lld method like uart_lld_init.
As always, if you disagree I'm very open to hearing why I'm wrong.
Thanks!