ChibiOS Free Embedded RTOS

Posted: **Mon Oct 17, 2016 11:33 am**

Hi,

I found a bug in the AVR SPI driver.

When doing multiple multi-byte SPI write operations, the Write Collision Flag (WCOL) bit in SPI Status Register (SPSR) gets set.
This is caused by calling

Code: Select all

_spi_isr_code(spip);

while the transmission is still in progress.

Attached is a patch to fix this issue.

Marco

Posted: **Mon Oct 17, 2016 11:54 am**

That patch doesn't seem to have been created against trunk. What version are you using?

Posted: **Mon Oct 17, 2016 12:13 pm**

No i'm sorry. I'm using the git mirror at commit 11eb96e. (svn://svn.code.sf.net/p/chibios/svn/trunk@9759).

Attached is the patch created against trunk.

Posted: **Mon Oct 17, 2016 12:18 pm**

Both patches apply the same changes.

Posted: **Mon Oct 17, 2016 12:25 pm**

Yes, i just recreated the patch with TortoiseSVN on the SVN trunk. The changes are the same.

Posted: **Mon Oct 17, 2016 1:02 pm**

The problem seemed to arrive from using patch on Mac OS X with CRLF line endings...

Applied, thanks!

ChibiOS Free Embedded RTOS

SPI Write Collision

SPI Write Collision

Re: SPI Write Collision

Re: SPI Write Collision

Re: SPI Write Collision

Re: SPI Write Collision

Re: SPI Write Collision