[PATCH] make the shell work on NIL again
Posted: Mon Aug 27, 2018 1:57 pm
Hi,
the shell doesn't compile in current trunk when used with NIL. The reason is that the chThdShouldTerminateX() and chEvtObjectInit() functions are missing.
I attached a patch to fix this. I made the whole shell thread exit logic optional with the SHELL_EXIT_ENABLED define. This is enabled by default on RT, but disabled on NIL.
I also added another patch with small output improvements.
Would it make sense to have a testcase with shell and NIL? For example in testhal or demos. Then it would be more easy to spot problems like this in the future.
Thanks for considering.
the shell doesn't compile in current trunk when used with NIL. The reason is that the chThdShouldTerminateX() and chEvtObjectInit() functions are missing.
I attached a patch to fix this. I made the whole shell thread exit logic optional with the SHELL_EXIT_ENABLED define. This is enabled by default on RT, but disabled on NIL.
I also added another patch with small output improvements.
Would it make sense to have a testcase with shell and NIL? For example in testhal or demos. Then it would be more easy to spot problems like this in the future.
Thanks for considering.