Page 1 of 1

[PATCH] make the shell work on NIL again

Posted: Mon Aug 27, 2018 1:57 pm
by electronic_eel
Hi,

the shell doesn't compile in current trunk when used with NIL. The reason is that the chThdShouldTerminateX() and chEvtObjectInit() functions are missing.

I attached a patch to fix this. I made the whole shell thread exit logic optional with the SHELL_EXIT_ENABLED define. This is enabled by default on RT, but disabled on NIL.

I also added another patch with small output improvements.

Would it make sense to have a testcase with shell and NIL? For example in testhal or demos. Then it would be more easy to spot problems like this in the future.

Thanks for considering.

Re: [PATCH] make the shell work on NIL again

Posted: Sun Jan 06, 2019 10:17 am
by Giovanni
Hi,

Not merging, next NIL will be able to create/exit threads (it is already working look under /branches/nil_4_dev).

Giovanni

Re: [PATCH] make the shell work on NIL again

Posted: Sun Jan 06, 2019 5:05 pm
by electronic_eel
Giovanni wrote:next NIL will be able to create/exit threads

That is an even better solution than mine, thanks ;)

Do you also plan to implement the full events source/listener mechanism for the next NIL release, as hinted here: [INFO] Nil growing (not in size)?

Re: [PATCH] make the shell work on NIL again

Posted: Sun Jan 06, 2019 5:08 pm
by Giovanni
Hi,

It is an open point, now it would be able to support it.

Giovanni