Page 1 of 1
Inconsistent location of HAL driver object declaration
Posted: Mon Oct 29, 2018 2:43 am
by faisal
The HAL driver object is defined in either in the top level hal_xxx.h file, or the hal_xxx_lld.h file depending on the driver. There should be one consistent pattern across all drivers.
Re: Inconsistent location of HAL driver object declaration
Posted: Mon Oct 29, 2018 5:02 am
by Giovanni
It is being moved at top level in new drivers, old drivers will be updated but it is not high priority.
Giovanni
Re: Inconsistent location of HAL driver object declaration
Posted: Mon Oct 29, 2018 5:18 am
by faisal
Giovanni wrote:It is being moved at top level in new drivers, old drivers will be updated but it is not high priority.
Giovanni
Cool, so the new standard is to have the definition in the top level header file, with platform specific structure members included as macros defined in the lld driver?
Re: Inconsistent location of HAL driver object declaration
Posted: Mon Oct 29, 2018 5:20 am
by Giovanni
Correct, I made the change in order to avoid duplicating the structures and related types in all LLDs.
This thing has an impact on other platforms: AVR, e200 etc so I am not pushing it for older drivers.
Giovanni