Page 1 of 1

Mismatch in hal_serial.h

Posted: Wed Aug 24, 2022 4:23 pm
by anotheruserofchibios
Hello,

On the master branch (actually from the original commit) it seems there is an extra argument in the call to iqReadI() from the macro sdReadI(), i.e. there should not be a timeout, so rather:

Code: Select all

#define sdReadI(sdp, b, n) iqReadI(&(sdp)->iqueue, b, n)


Also I am wondering if the documentation of sdReadI() & sdWriteI() is correct about being blocking read/write since their iqReadI() & oqWriteI() counterparts claim they are non-blocking read/write.

Re: Mismatch in hal_serial.h

Posted: Wed Aug 24, 2022 8:31 pm
by Giovanni
Hi,

Probably the oldest bug ever found :-)

I will look into the documentation mismatch, "i" functions cannot be blocking obviously,

Giovanni

Re: Mismatch in hal_serial.h

Posted: Sun Sep 18, 2022 10:49 am
by Giovanni
Hi,

Fixed as bug #1236.

Giovanni