Bug in ext_lld.c?

ChibiOS public support forum for topics related to the Atmel AT91SAM7x family of micro-controllers.
Post Reply
User avatar
lilvinz
Posts: 130
Joined: Sat Dec 21, 2013 2:56 pm
Has thanked: 1 time
Been thanked: 6 times

Bug in ext_lld.c?

Post by lilvinz »

Hi,

for STM32, ext callbacks are execute without system lock, this driver sets a system lock before invoking callbacks.
I assume this to be a bug as it prevents portability between platforms.
Can someone please confirm this?

Cheers,

Vinz
User avatar
Giovanni
Site Admin
Posts: 14891
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 996 times

Re: Bug in ext_lld.c?

Post by Giovanni »

By convention callbacks should be called outside critical zones, it would be a bug.

Giovanni
User avatar
lilvinz
Posts: 130
Joined: Sat Dec 21, 2013 2:56 pm
Has thanked: 1 time
Been thanked: 6 times

Re: Bug in ext_lld.c?

Post by lilvinz »

Thanks for the quick reply.
The fix seems easy as i don't see a reason for the driver to enter a lock zone anyway.

Cheers,

Vinz
Post Reply