STM32F4xx CRC hal bug Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
Post Reply
User avatar
kimmoli
Posts: 26
Joined: Sat Oct 01, 2016 8:02 pm
Has thanked: 11 times
Been thanked: 8 times

STM32F4xx CRC hal bug

Post by kimmoli »

I think i found a bug from STM32 CRC HAL. These asserts will trigger when !(config != default_config), and IMHO just reverse is expeceted. If someone can comply, i will make a PR.

https://github.com/kimmoli/ChibiOS-Cont ... 15e832610d

Also in the main ChibiOS side, there are no STM32F4xx defines for CRC RCC controls;

https://github.com/kimmoli/ChibiOS/comm ... 7d6fcc0951
User avatar
Giovanni
Site Admin
Posts: 14893
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 997 times

Re: STM32F4xx CRC hal bug

Post by Giovanni »

Moving in bug reports.

Giovanni
User avatar
Giovanni
Site Admin
Posts: 14893
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 997 times

Re: STM32F4xx CRC hal bug

Post by Giovanni »

Note, you should ping the author, community code is not handled by me.

Giovanni
User avatar
kimmoli
Posts: 26
Joined: Sat Oct 01, 2016 8:02 pm
Has thanked: 11 times
Been thanked: 8 times

Re: STM32F4xx CRC hal bug

Post by kimmoli »

Community part has already been berged https://github.com/ChibiOS/ChibiOS-Contrib/pull/98
User avatar
kimmoli
Posts: 26
Joined: Sat Oct 01, 2016 8:02 pm
Has thanked: 11 times
Been thanked: 8 times

Re: STM32F4xx CRC hal bug

Post by kimmoli »

Contribution side merged.
Split Chibios part in viewtopic.php?f=35&t=3696
Post Reply