Allow forward declaration of chibios hal structs Topic is solved

[rolanddixon]

Hi All,

This is a fairly simple request and I do not mind submitting a patch for it but I thought I would ask as it could be against a previous design decision.

I will use the SerialConfig as an example. Currently the structure is defined as:

Code: Select all

typedef struct
{
   uint32_t speed;
   ...
} SerialConfig;

This has the adverse effect that it cannot be forward declared. Instead the struct could look like the following:

Code: Select all

typedef struct _SerialConfig
{
   uint32_t speed;
   ...
} SerialConfig;

This would allow for forward declaration as:

Code: Select all

typedef struct _SerialConfig SerialConfig;

As far as I can tell, it would only be the definitions that need updating and the actual source code will remain the same.

This is useful when implementing pimpl and factory type patterns in C++.

[Giovanni]

Hi,

This is already done for some (newer) drivers, see hal_sio.h for example. If you are going to propose a patch please follow comment and naming patterns as seen in that file.

Giovanni

[rolanddixon]

Ok, yes. I'll submit one patch at a time per driver if that is OK with you.

Roland

[rolanddixon]

Here is the first hal_serial patch. I have applied it and built all code in "testhal". All the arm based code compiles file. Some of the AVR based code fails but not due to the changes I made. I probably have a mismatch of version of the avr-gcc compiler.

I have zipped the patch along with the build log text file.

I used "git diff --no-prefix" to generate the patch which can be appled with "patch -p0 << /path/to/patch/patch.diff" in the root of the repo.

[rolanddixon]

Here are the can, uart and serial patches.
These are the peripherals that I am using at the moment. I will upload the other when I use the peripherals which won't be for a while.

[Giovanni]

Thanks, will apply.

Giovanni

[rolanddixon]

Hi Giovanni,

It has been a while but here is a patch for the i2c driver and config typedefs (hal_i2c_config and hal_i2c_driver).

I have tested the builds for the STM32 testhal projects.

[Giovanni]

Hi,

Thanks, will try it tomorrow.

Giovanni

[Giovanni]

Thanks, patch applied.

Giovanni