In file stm32f4xx.h #defines for FSMC missing

ChibiOS public support forum for topics related to the STMicroelectronics STM32 family of micro-controllers.

Moderator: RoccoMarco

Post Reply
NixToDo
Posts: 1
Joined: Sat Jan 04, 2014 2:58 pm

In file stm32f4xx.h #defines for FSMC missing

Post by NixToDo »

Hi,

I have found missing #define statements for the FSMC in file:
/os/hal/platforms/STM32F4xx/stm32f4xx.h

At registers FSMC_BTR[1..4] and FSMC_RWTR[1..4] the Bits [7:4] of DATAST are missing in #define statements.
The DATAST field is the only one with 8 Bits, all others have 4 Bits ;)

I have attached a SVN patch file as ZIP, because the forum not allow uploading .patch files.

Buy.
Attachments
stm32f4xx.h.zip
(980 Bytes) Downloaded 323 times
User avatar
Giovanni
Site Admin
Posts: 14892
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 996 times

Re: In file stm32f4xx.h #defines for FSMC missing

Post by Giovanni »

Hi,

Thanks for the file but should we be fixing vendor-provided files? in this case it should be ST fixing that (and good luck with that :)).

Giovanni
Post Reply