Minor change to rules.ld, does not give expected result

ChibiOS public support forum for topics related to the STMicroelectronics STM32 family of micro-controllers.

Moderator: RoccoMarco

Post Reply
User avatar
Korken
Posts: 270
Joined: Wed Apr 02, 2014 4:09 pm
Has thanked: 5 times
Been thanked: 6 times

Minor change to rules.ld, does not give expected result

Post by Korken »

Hi all,

I have been using a modified version of the rules.ld files to have a small string at a specified location in memory.
This is how the change looks:

Code: Select all

...

    startup : ALIGN(16) SUBALIGN(16)
    {
        KEEP(*(.vectors))
    } > flash
   
    version_information : ALIGN(4) SUBALIGN(4)
    {
        KEEP(*(.sw_version))
    } > flash

    constructors : ALIGN(4) SUBALIGN(4)
    {
        PROVIDE(__init_array_start = .);
        KEEP(*(SORT(.init_array.*)))
        KEEP(*(.init_array))
        PROVIDE(__init_array_end = .);
    } > flash

...
Where I have added the version_information.
This has worked nicely and put the string after the vector table, but after the latest commits I had to update the file with the new RAM definitions and the updated makefile.
And now when I use "__attribute__ ((used, section(".sw_version")))" it does not put the string in version_information, but next to .rodata.
Ofcourse I have made sure that my own STM32F405xG.ld (that points to my rules.ld) and changed in the Makefile so I have LDSCRIPT= make/STM32F405xG.ld (where my linker scripts are located).

Have I missed some new tag that must be added to my own section or what could be causing this error?

I have also tried to put by definition in the startup section as:

Code: Select all

    startup : ALIGN(16) SUBALIGN(16)
    {
        KEEP(*(.vectors))
        KEEP(*(.sw_version))
    } > flash
Which made no difference, the string is still put in .rodata.
However if I use "__attribute__ ((used, section(".vectors")))" it is placed after vectors, so it is as if my section is not recognised.

Thanks for any help!

Best Regards
Emil

My makefile if needed:

Code: Select all

##############################################################################
# Build global options
# NOTE: Can be overridden externally.
#

# Compiler options here.
ifeq ($(USE_OPT),)
  USE_OPT = -O0 -ggdb -fomit-frame-pointer -falign-functions=16
endif

# C specific options here (added to USE_OPT).
ifeq ($(USE_COPT),)
  USE_COPT =
endif

# C++ specific options here (added to USE_OPT).
ifeq ($(USE_CPPOPT),)
  USE_CPPOPT = -fno-rtti
endif

# Enable this if you want the linker to remove unused code and data
ifeq ($(USE_LINK_GC),)
  USE_LINK_GC = no
endif

# Linker extra options here.
ifeq ($(USE_LDOPT),)
  USE_LDOPT = -lm
endif

# Enable this if you want link time optimizations (LTO)
ifeq ($(USE_LTO),)
  USE_LTO = no
endif

# If enabled, this option allows to compile the application in THUMB mode.
ifeq ($(USE_THUMB),)
  USE_THUMB = yes
endif

# Enable this if you want to see the full log while compiling.
ifeq ($(USE_VERBOSE_COMPILE),)
  USE_VERBOSE_COMPILE = no
endif

#
# Build global options
##############################################################################

##############################################################################
# Architecture or project specific options
#

# Stack size to be allocated to the Cortex-M process stack. This stack is
# the stack used by the main() thread.
ifeq ($(USE_PROCESS_STACKSIZE),)
  USE_PROCESS_STACKSIZE = 0x400
endif

# Stack size to the allocated to the Cortex-M main/exceptions stack. This
# stack is used for processing interrupts and exceptions.
ifeq ($(USE_EXCEPTIONS_STACKSIZE),)
  USE_EXCEPTIONS_STACKSIZE = 0x400
endif

# Enables the use of FPU on Cortex-M4 (no, softfp, hard).
ifeq ($(USE_FPU),)
  USE_FPU = hard
endif

#
# Architecture or project specific options
##############################################################################

##############################################################################
# Project, sources and paths
#

# Define project name here
PROJECT = kfly

# Create include paths and find sources of all the modules
MODULES = $(wildcard ./modules/*)
$(foreach dir, $(MODULES) , $(eval MODULES_INC += $(dir)/inc))
$(foreach dir, $(MODULES), $(eval MODULES_CSRCS += $(wildcard $(dir)/src/*.c)))
$(foreach dir, $(MODULES), $(eval MODULES_ASRCS += $(wildcard $(dir)/src/*.s)))

# Imported source files and paths
CHIBIOS = ../ChibiOS
# Startup files.
include $(CHIBIOS)/os/common/ports/ARMCMx/compilers/GCC/mk/startup_stm32f4xx.mk
# HAL-OSAL files (optional).
include $(CHIBIOS)/os/hal/hal.mk
include $(CHIBIOS)/os/hal/ports/STM32/STM32F4xx/platform.mk
include board/board.mk
include $(CHIBIOS)/os/hal/osal/rt/osal.mk
# RTOS files (optional).
include $(CHIBIOS)/os/rt/rt.mk
include $(CHIBIOS)/os/rt/ports/ARMCMx/compilers/GCC/mk/port_v7m.mk
# Other files (optional).
include system/system.mk
include drivers/drivers.mk

# Define linker script file here
LDSCRIPT= make/STM32F405xG.ld

# C sources that can be compiled in ARM or THUMB mode depending on the global
# setting.
CSRC = $(STARTUPSRC) \
       $(KERNSRC) \
       $(PORTSRC) \
       $(OSALSRC) \
       $(HALSRC) \
       $(PLATFORMSRC) \
       $(BOARDSRC) \
       $(SYSTEMSRC) \
       $(ADRIVERSSRC) \
       $(CHIBIOS)/os/hal/lib/streams/memstreams.c \
       $(CHIBIOS)/os/hal/lib/streams/chprintf.c \
       main.c \
       $(MODULES_CSRCS)

# C++ sources that can be compiled in ARM or THUMB mode depending on the global
# setting.
CPPSRC =

# C sources to be compiled in ARM mode regardless of the global setting.
# NOTE: Mixing ARM and THUMB mode enables the -mthumb-interwork compiler
#       option that results in lower performance and larger code size.
ACSRC =

# C++ sources to be compiled in ARM mode regardless of the global setting.
# NOTE: Mixing ARM and THUMB mode enables the -mthumb-interwork compiler
#       option that results in lower performance and larger code size.
ACPPSRC =

# C sources to be compiled in THUMB mode regardless of the global setting.
# NOTE: Mixing ARM and THUMB mode enables the -mthumb-interwork compiler
#       option that results in lower performance and larger code size.
TCSRC =

# C sources to be compiled in THUMB mode regardless of the global setting.
# NOTE: Mixing ARM and THUMB mode enables the -mthumb-interwork compiler
#       option that results in lower performance and larger code size.
TCPPSRC =

# List ASM source files here
ASMSRC = $(STARTUPASM) $(PORTASM) $(OSALASM) $(MODULES_ASRCS)

INCDIR = $(STARTUPINC) $(KERNINC) $(PORTINC) $(OSALINC) \
         $(HALINC) $(PLATFORMINC) $(BOARDINC) $(SYSTEMINC) \
         $(ADRIVERSINC) $(CHIBIOS)/os/hal/lib/streams $(CHIBIOS)/os/various \
         $(MODULES_INC)

#
# Project, sources and paths
##############################################################################

##############################################################################
# Compiler settings
#

MCU  = cortex-m4

#TRGT = arm-elf-
TRGT = arm-none-eabi-
CC   = $(TRGT)gcc
CPPC = $(TRGT)g++
# Enable loading with g++ only if you need C++ runtime support.
# NOTE: You can use C++ even without C++ support if you are careful. C++
#       runtime support makes code size explode.
LD   = $(TRGT)gcc
#LD   = $(TRGT)g++
CP   = $(TRGT)objcopy
AS   = $(TRGT)gcc -x assembler-with-cpp
OD   = $(TRGT)objdump
SZ   = $(TRGT)size
HEX  = $(CP) -O ihex
BIN  = $(CP) -O binary

# ARM-specific options here
AOPT =

# THUMB-specific options here
TOPT = -mthumb -DTHUMB

# Define C warning options here
CWARN = -Wall -Wextra -Wstrict-prototypes

# Define C++ warning options here
CPPWARN = -Wall -Wextra

#
# Compiler settings
##############################################################################

##############################################################################
# Start of default section
#

EMPTY :=

# Get Date
ifeq ($(OS),Windows_NT)
  GIT_DATE = $(shell $(subst /,\\,./make/date.bat))
else
  GIT_DATE = 20$(shell date +'%y%m%d-%H:%M')
endif


# Get Git Tags
GIT_TAGS := $(shell git describe --tags HEAD)
GIT_SHORTSTAT := $(shell git diff --name-only)

ifeq ($(GIT_SHORTSTAT),$(EMPTY))
   GIT_DIRTY := $(EMPTY)
else
   GIT_DIRTY := ~dirty
endif
GIT_VERSION := $(GIT_TAGS)$(GIT_DIRTY)

# List all default C defines here, like -D_DEBUG=1
DDEFS = -DGIT_VERSION=$(GIT_VERSION) -DDATE=$(GIT_DATE)

# List all default ASM defines here, like -D_DEBUG=1
DADEFS =

# List all default directories to look for include files here
DINCDIR =

# List the default directory to look for the libraries here
DLIBDIR =

# List all default libraries here
DLIBS =

#
# End of default section
##############################################################################

##############################################################################
# Start of user section
#

# List all user C define here, like -D_DEBUG=1
UDEFS =

# Define ASM defines here
UADEFS =

# List all user directories here
UINCDIR =

# List the user directory to look for the libraries here
ULIBDIR =

# List all user libraries here
ULIBS =

#
# End of user defines
##############################################################################

RULESPATH = $(CHIBIOS)/os/common/ports/ARMCMx/compilers/GCC
include $(RULESPATH)/rules.mk
User avatar
Giovanni
Site Admin
Posts: 14892
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 996 times

Re: Minor change to rules.ld, does not give expected result

Post by Giovanni »

You should inspect the map file and see if the section is really .sw_version or the compiler adds something else to it.

Giovanni
User avatar
Korken
Posts: 270
Joined: Wed Apr 02, 2014 4:09 pm
Has thanked: 5 times
Been thanked: 6 times

Re: Minor change to rules.ld, does not give expected result

Post by Korken »

Hi, thanks for the response!

The section is defined at least:

Code: Select all

.sw_version     0x0801bf74       0x50
 .sw_version    0x0801bf90       0x34 build/obj/version_information.o
                0x0801bf90                build_version

However it is not with the sections in the start, but far in the end:

Code: Select all

...
startup         0x08000000      0x1c0
 *(.vectors)
 .vectors       0x08000000      0x1c0 build/obj/vectors.o
                0x08000000                _vectors

constructors    0x080001c0        0x0
                0x080001c0                PROVIDE (__init_array_start, .)
 *(SORT(.init_array.*))
 *(.init_array)
                0x080001c0                PROVIDE (__init_array_end, .)

destructors     0x080001c0        0x0
                0x080001c0                PROVIDE (__fini_array_start, .)
 *(.fini_array)
 *(SORT(.fini_array.*))
                0x080001c0                PROVIDE (__fini_array_end, .)

.text           0x080001c0    0x1bdb4
 *(.text)
 .text          0x080001c0       0xf4 build/obj/crt0_v7m.o
...


It's just as if it did not see my newly defined section.
Any ideas where to start looking?
User avatar
Korken
Posts: 270
Joined: Wed Apr 02, 2014 4:09 pm
Has thanked: 5 times
Been thanked: 6 times

Re: Minor change to rules.ld, does not give expected result

Post by Korken »

I found the problem! (Not sure what is wrong though)
If I changed LDSCRIPT = make/STM32F405xG.ld to LDSCRIPT = ./make/STM32F405xG.ld it's working as it should.
Somehow when I did not have it it found the original STM32F405xG.ld in the ChibiOS folder.

Thanks for looking into it though! :)
Do you know why this minor change made such a big difference?
User avatar
Giovanni
Site Admin
Posts: 14892
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 996 times

Re: Minor change to rules.ld, does not give expected result

Post by Giovanni »

Reasons behind LD inner working are arcane....

Giovanni
Post Reply