Missing defintion in STM32F4 hal_lld.c Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
Post Reply
neums
Posts: 137
Joined: Fri May 08, 2015 1:09 pm
Has thanked: 10 times
Been thanked: 5 times

Missing defintion in STM32F4 hal_lld.c

Post by neums »

Hi,
in the hal_lld.c of th STM32F4 the definition STM32_PLLSAIR_POST is used in the function void stm32_clock_init(void) but it is not defined at all. Is this a bug?

Thanks
neums
Posts: 137
Joined: Fri May 08, 2015 1:09 pm
Has thanked: 10 times
Been thanked: 5 times

Re: Missing defintion in STM32F4 hal_lld.c

Post by neums »

It is also not defined in the reference manual.
User avatar
RoccoMarco
Posts: 655
Joined: Wed Apr 24, 2013 4:11 pm
Has thanked: 83 times
Been thanked: 67 times

Re: Missing defintion in STM32F4 hal_lld.c

Post by RoccoMarco »

Hi,
maybe it is defined in CM-SIS headers. Note that certain parts depends on specific MCUs
neums
Posts: 137
Joined: Fri May 08, 2015 1:09 pm
Has thanked: 10 times
Been thanked: 5 times

Re: Missing defintion in STM32F4 hal_lld.c

Post by neums »

STM32_PLLSAIR_POST is not defined in any cmsis header file.
User avatar
RoccoMarco
Posts: 655
Joined: Wed Apr 24, 2013 4:11 pm
Has thanked: 83 times
Been thanked: 67 times

Re: Missing defintion in STM32F4 hal_lld.c

Post by RoccoMarco »

clock init for STM32F4 has been already edited on trunk and this line has been completely removed. Since the whole edit impacts on certain features it has not been backported to 16.1.x and will be released with 17.x.

The question is: this line causes some compile error or unwanted behaviour on 16.1.x? If the answer is yes how can I reproduce that condition?
User avatar
Giovanni
Site Admin
Posts: 14893
Joined: Wed May 27, 2009 8:48 am
Has thanked: 1202 times
Been thanked: 997 times

Re: Missing defintion in STM32F4 hal_lld.c

Post by Giovanni »

Fixed as bug #834.

Giovanni
Post Reply